Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lang): Add missing translations for French, Italian, Japanese, and Korean #7589

Merged
merged 4 commits into from
Feb 23, 2022
Merged

fix(lang): Add missing translations for French, Italian, Japanese, and Korean #7589

merged 4 commits into from
Feb 23, 2022

Conversation

Noemite
Copy link
Contributor

@Noemite Noemite commented Jan 3, 2022

Description

Add translation for italian, french, japanese and korean language.

Specific Changes proposed

Please list the specific changes involved in this pull request.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@welcome
Copy link

welcome bot commented Jan 3, 2022

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

misteroneill
misteroneill approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@misteroneill misteroneill added the needs: LGTM Needs one or more additional approvals label Jan 10, 2022
@misteroneill misteroneill changed the title Add lang fix(lang): Add missing translations for French, Italian, Japanese, and Korean Jan 10, 2022
@misteroneill misteroneill added confirmed patch This PR can be added to a patch release. and removed needs: LGTM Needs one or more additional approvals labels Jan 11, 2022
@misteroneill misteroneill merged commit b5f775e into videojs:main Feb 23, 2022
@welcome
Copy link

welcome bot commented Feb 23, 2022

Congrats on merging your first pull request! 🎉🎉🎉

This was referenced Jul 18, 2022
Closed
Merged
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
@Noemite @edirub
fix(lang): Add missing translations for French, Italian, Japanese, an…
3189343 
…d Korean (videojs#7589)

Co-authored-by: Noémie Macault <noemie.macault@capgemini.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misteroneill misteroneill misteroneill approved these changes

@mister-ben mister-ben mister-ben approved these changes

Assignees
No one assigned
Labels
confirmed patch This PR can be added to a patch release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Noemite @misteroneill @mister-ben