From 7826e8c83e886d6ebd4ef8cfcf56525c16001463 Mon Sep 17 00:00:00 2001 From: Grzegorz Blaszczyk Date: Tue, 10 May 2022 13:06:12 +0200 Subject: [PATCH 1/2] fix(accessibility): frame must have a title attribute --- src/js/resize-manager.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/js/resize-manager.js b/src/js/resize-manager.js index 0086e4a6d0..58312e0730 100644 --- a/src/js/resize-manager.js +++ b/src/js/resize-manager.js @@ -92,7 +92,8 @@ class ResizeManager extends Component { createEl() { return super.createEl('iframe', { className: 'vjs-resize-manager', - tabIndex: -1 + tabIndex: -1, + title: 'No content' }, { 'aria-hidden': 'true' }); From 5afc7a1db6ee94c34b72a3b562fc0521b930b03f Mon Sep 17 00:00:00 2001 From: Grzegorz Blaszczyk Date: Sun, 15 May 2022 13:26:07 +0200 Subject: [PATCH 2/2] fix(accessibility): localizes a title attribute message in resize manager --- lang/en.json | 3 ++- src/js/resize-manager.js | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lang/en.json b/lang/en.json index 649120c555..8a3440b0d9 100644 --- a/lang/en.json +++ b/lang/en.json @@ -85,5 +85,6 @@ "End of dialog window.": "End of dialog window.", "{1} is loading.": "{1} is loading.", "Exit Picture-in-Picture": "Exit Picture-in-Picture", - "Picture-in-Picture": "Picture-in-Picture" + "Picture-in-Picture": "Picture-in-Picture", + "No content": "No content" } diff --git a/src/js/resize-manager.js b/src/js/resize-manager.js index 58312e0730..63296d5aa2 100644 --- a/src/js/resize-manager.js +++ b/src/js/resize-manager.js @@ -93,7 +93,7 @@ class ResizeManager extends Component { return super.createEl('iframe', { className: 'vjs-resize-manager', tabIndex: -1, - title: 'No content' + title: this.localize('No content') }, { 'aria-hidden': 'true' });