fix: improves types for registerPlugin and getPlugin #8058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #8058 +/- ##
=======================================
Coverage 81.91% 81.91%
=======================================
Files 110 110
Lines 7342 7342
Branches 1772 1772
=======================================
Hits 6014 6014
Misses 1328 1328
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mister-ben
approved these changes
Dec 23, 2022
gjanblaszczyk
commented
Dec 23, 2022
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
* fix: improves types for registerPlugin and getPlugin
* fix: corrects parameter type for registerPlugin
* docs(fix): add support for {typeof class} expression
* chore: move js-doc-typeof-plugin to build dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR fixes the issue #8050
Specific Changes proposed
It modifies player docs for registerPlugin and getPlugin methods.
Requirements Checklist