Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Refresh README.md and point other docs to admin repo #8837

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

misteroneill
Copy link
Member

Description

This is a long-needed update to the Video.js README. Also, other docs are now pointing to files in the videojs/admin repo.

Specific Changes proposed

  • Refresh Video.js README.
    • Removes the old discussion of the Google Analytics tracking pixel in vjs.zencdn.net-hosted versions prior to 7.0.0. The last version that included this was 6.13.0, which was 6 years ago. That seems like enough time to consider the issue dead. Also, Google Analytics likely no longer collects that data as it has moved on from the Universal Analytics API.
  • The following docs are moved to the videojs/admin repo, but the files are kept here and link to the replacements for discoverability:
    • CODE_OF_CONDUCT.md
    • COLLABORATOR_GUIDE.md
    • CONTRIBUTING.md

Requirements Checklist

  • Feature implemented / Bug fixed
  • Reviewed by Two Core Contributors

@misteroneill misteroneill added the needs: LGTM Needs one or more additional approvals label Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.18%. Comparing base (73db132) to head (0f10a65).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8837   +/-   ##
=======================================
  Coverage   83.18%   83.18%           
=======================================
  Files         120      120           
  Lines        8047     8047           
  Branches     1931     1931           
=======================================
  Hits         6694     6694           
  Misses       1353     1353           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
misteroneill and others added 2 commits August 23, 2024 11:55
Co-authored-by: mister-ben <1676039+mister-ben@users.noreply.github.com>
Copy link
Contributor

@amtins amtins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@misteroneill misteroneill merged commit f0db8f1 into main Aug 23, 2024
14 checks passed
@misteroneill misteroneill deleted the admin-docs branch August 23, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: LGTM Needs one or more additional approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants