SeekHandle content #902
SeekHandle content #902
Conversation
I wanted to use the SeekHandle to show the current time but as far as I could tell it only contained static content, I made this change to allow the content to be updated. Is this its intended purpose or am I playing with something that has another a different job?
|
Sorry for the slow response to this one. The seek handle used to support this and wasn't updated after the latest big rewrite. So the 00:00 is still there but it does need this update. It won't be shown in the default skin, but the hope is to make it easy for anyone to make a skin that shows the time above the seek handle, if that's what's desired. I'll need to play around with this for a bit to make sure it doesn't conflict, and there were some changes that updated time cacheing. |
| className: 'vjs-seek-handle' | ||
| }); | ||
| vjs.SeekHandle.prototype.createEl = function() { | ||
| return this.content = vjs.SliderHandle.prototype.createEl.call(this, 'div', { |
There was a problem hiding this comment.
I think you could use this.el() in the same way you're using this.content here. Let me know if there was a specific reason for creating a new property in addition to el().
|
@gdkraus, after this update the slider handle's content will update with the current time. Do you know if it should it have an |
|
Thanks for the addition @MrAvenger! |
|
@heff, I don't remember dealing with the text field updating when I made the accessibility changes about a year ago. Is that a new field? Nonetheless, it should be set to aria-live="off" because the |
|
Great, thanks! FWIW, it does look like you added it. |
I wanted to use the SeekHandle to show the current time but as far as I could tell it only contained static content, I made this change to allow the content to be updated.
Is this its intended purpose or am I playing with something that has a different job?