set contentresuming before calling adBreak.end #418
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On IE11, we can potentially receive a
play
event beforeadBreak.end()
completes and thus before we setthis.contentResuming = true;
. This results in thatplay
event being prefixed as anad-play
event sincecontentResuming
is stillfalse
until afterend
completes.This fix simply moves
this.contentResuming = true;
above theAdBreak.end()
call which is in line with what we are also doing inMidroll.js
.Logically, this makes sense because we are adding the
vjs-ad-content-resuming
class to the player as a signal to the UI that we are done playing ads.Tested on IE11 on Win7 and on Mac OS X Chrome 67.