Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set contentresuming before calling adBreak.end #418

Merged
merged 1 commit into from
Aug 31, 2018

Conversation

marguinbc
Copy link
Contributor

On IE11, we can potentially receive a play event before adBreak.end() completes and thus before we set this.contentResuming = true;. This results in that play event being prefixed as an ad-play event since contentResuming is still false until after end completes.

This fix simply moves this.contentResuming = true; above the AdBreak.end() call which is in line with what we are also doing in Midroll.js.

Logically, this makes sense because we are adding thevjs-ad-content-resuming class to the player as a signal to the UI that we are done playing ads.

Tested on IE11 on Win7 and on Mac OS X Chrome 67.

@apadhye
Copy link

apadhye commented Aug 28, 2018

QA LGTM.

@incompl incompl merged commit 627e94b into videojs:master Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants