fix: Avoid multiple-registration warning messages by accepting only the first contrib-ads per context. #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should also go into the same release as #415. |
incompl
reviewed
Aug 20, 2018
src/register.js
Outdated
| return Boolean(videojs.getPlugin(NAME)); | ||
| } | ||
|
|
||
| const Player = videojs.getComponent('Player'); |
There was a problem hiding this comment.
I think a comment would be useful here, I'm not sure why this check is needed.
src/register.js
Outdated
| const {playMiddleware, isMiddlewareMediatorSupported} = playMiddlewareFeature; | ||
|
|
||
| // The plugin name. | ||
| const NAME = 'ads'; |
There was a problem hiding this comment.
I recognize it's subjective, but extracting this to a variable doesn't seem valuable to me. The string is not likely to change and I don't see this as providing extra safety in this case. Importing it in other files seems tedious.
incompl
approved these changes
Aug 21, 2018
…he first contrib-ads per context.
misteroneill
force-pushed
the
dupe-detection
branch
from
78fd068
to
5189016
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #415, will change the base branch after that PR is merged.
Someone could still de-register contrib-ads, but that will not affect the middleware, so code now exists to ensure that middleware is only defined once by contrib-ads (from this version on).