ArgumentTypeCoercion for static in 3.11.0

[vudaltsov]

https://psalm.dev/r/cc4ea0abe5
I think this is the correct behavior of Psalm, just want to make sure I understand the edge case.

If I have abstract class AbstractId extends Id and then Ids<AbstractId>, the Ids<AbstractId>::contains method will not work correctly, right?

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/cc4ea0abe5

<?php

/**
 * @psalm-immutable
 */
abstract class Id
{
    protected string $id;

    final protected function __construct(string $id)
    {
        $this->id = $id;
    }
    
    /**
     * @param static $id
     */
    final public function equals(self $id): bool
    {
        return $this->id === $id->id;
    }
}

/**
 * @template T of Id
 */
final class Ids
{
    /**
     * @psalm-var list<T>
     */
    private array $ids;

    /**
     * @psalm-param list<T> $ids
     */
    private function __construct(array $ids)
    {
        $this->ids = $ids;
    }

    /**
     * @psalm-param T $id
     */
    public function contains(Id $id): bool
    {
        foreach ($this->ids as $oneId) {
            if ($oneId->equals($id)) {
                return true;
            }
        }

        return false;
    }
}

Psalm output (using commit 5bc9b09):

ERROR: ArgumentTypeCoercion - 48:32 - Argument 1 of Id::equals expects Id&static, parent type T:Ids as Id provided

[weirdan]

I think this is the correct behavior of Psalm,

Why do you think it's correct?

[vudaltsov]

@weirdan , as I said, if I have abstract class AbstractId extends Id and then Ids<AbstractId>, the Ids<AbstractId>::contains method will not be able to check that Id::equals is called against static.

[vudaltsov]

Okay, maybe I am overthinking this and it's just a bug :)