Document how the extension searches the ADB.exe on the system.

[vinicioslc]

Explain in readme.md how the extension try to find the adb.exe and explain how the option ADB:📱 Setup custom ADB location works on README.md.

Requirements:

• Put the command on commands list section of README.md
• Create another paragraph at end of README.md describing how ADB:📱 Setup custom ADB location works and the strategy behind.
• Found a bug

This issue could be helpful for initial contributors, that want to learn about the extension, but don't know where start, so... start studying the code responsible by find ADB wrapper.

[moozzyk]

I am wondering if the custom path is actually ever set. If I read the code correctly here is the code that is getting the path from the UI and is supposed to save it:

adb-interface-vscode/src/controllers/adb-path-controller/index.ts

Lines 48 to 60 in 24bb563

	vscode.window.showOpenDialog(options).then(fileUri => {
	if (fileUri && fileUri[0]) {
	// replace filename with path
	const adbPath = fileUri[0].fsPath.replace(
	RegExp(path.basename(fileUri[0].fsPath) + '$', 'i'),
	''
	)
	console.log('Selected file: ' + fileUri[0].fsPath)
	console.log('Selected file: ' + adbPath)
	vscode.window.showInformationMessage(
	'Custom ADB path setted:' + adbPath
	)
	}

but I don't see the path being actually saved (i.e. there is no call to this.pathManagerInstance.setFilePath).

[vinicioslc]

Apparently, in addition to documenting you found a bug ahahah, congratulations!
I created a new issue referencing this and also suggested an addition in your pull request (on markdown) to make it perfect.

Thank you for your contribution.

[moozzyk]

I updated the PR as suggested. Also I realized that the PR was opened against a wrong repo so created a new PR that now shows up in PRs here.

[vinicioslc]

I also noticed this detail about the wrong repo haha, thanks for the contribution!

Oh and also, congratulations on your work at SignalR Swift, i really appreciate your work.

[moozzyk]

Thanks!