Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test to avoid repetition of Quotes #120

Open
vinitshahdeo opened this issue Oct 4, 2019 · 15 comments · May be fixed by #2278
Open

Test to avoid repetition of Quotes #120

vinitshahdeo opened this issue Oct 4, 2019 · 15 comments · May be fixed by #2278
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Send PR and earn a free t-shirt help wanted Extra attention is needed unit-tests missing Add mocha tests

Comments

@vinitshahdeo
Copy link
Owner

vinitshahdeo commented Oct 4, 2019

It's difficult to check manually whether the new-quote added already exists or not?

Adding Mocha test for checking the repetition of quotes in data.json would be great to check.

Somebody, please add unit tests for it.

NOTE:

  • Add unit-tests inside tests/ directory.
  • Update the dependencies and test-scripts in package.json
  • Update README.md with instructions to run tests (i.e. npm run test)
  • Do not make any other changes.
@vinitshahdeo vinitshahdeo added good first issue Good for newcomers help wanted Extra attention is needed enhancement New feature or request hacktoberfest Send PR and earn a free t-shirt unit-tests missing Add mocha tests labels Oct 4, 2019
@ghost
Copy link

ghost commented Oct 4, 2019

I want to take this issue

@vinitshahdeo
Copy link
Owner Author

@TheShivaa Please go ahead!

@bvamsik25
Copy link

@vinitshahdeo Can I ?

@ghost
Copy link

ghost commented Oct 16, 2019

@bvamsik25 u can go ahead with this , I am stuck in different work

@bvamsik25
Copy link

ok thanks !

@muhamadtarek
Copy link

hey i am trying to implement this contribute with you guys!!

@vinitshahdeo
Copy link
Owner Author

@mohamed93727 That's great:) 👍

@Project-Magenta
Copy link

I want to imolement this for hacktoberfest but i have never used unit tests :(

@vinitshahdeo
Copy link
Owner Author

@Project-Magenta Give it a try or you may look into a few good first issues which are up for grabs.

Link to the repository

@nessieSnippets
Copy link

I tried doing this using a JavaScript set : #510, what do you think?

Sorry if I've completely missed your PRs on this (I'm new to contributions, I got into it from hacktoberfest too). Please let me know & I'll try and review.

@Project-Magenta
Copy link

ok thx @vinitshahdeo

@vinitshahdeo
Copy link
Owner Author

@nessieSnippets Thanks for the PR. I'll review and merge it soon.

@barunsarraf
Copy link

Hi I am looking forward to contributing to this issue :)

@SwarajBaral
Copy link

hey @vinitshahdeo is this issue still open ? I would love to work on this issue.

@rajeshmr82 rajeshmr82 linked a pull request Oct 6, 2021 that will close this issue
@Sheikh-Yawar
Copy link

hey @vinitshahdeo is this issue still open ? I would like to contribute to this project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Send PR and earn a free t-shirt help wanted Extra attention is needed unit-tests missing Add mocha tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants