Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry logic to RecordSetChangesListAll and RecordSetsListAll #88

Open
1 task done
jhg03a opened this issue Apr 19, 2022 · 1 comment
Open
1 task done

Add retry logic to RecordSetChangesListAll and RecordSetsListAll #88

jhg03a opened this issue Apr 19, 2022 · 1 comment

Comments

@jhg03a
Copy link
Contributor

jhg03a commented Apr 19, 2022

Prerequisites

  • Put an X between the brackets on this line if you have done all of the following:
    • Checked that your issue isn't already filed.

Description

As a user trying to obtain all recordset changes on a large zone, I'd like to have retry logic introduced inside the code handling pagination of changes. I can implement my own retry logic, but for large zones it means I have to start over each time amplifying server load rather than letting the pagination aspects handle it on my behalf to pick up. This specifically is from cases where the vinyldns API returns a 503 and response body of The server was not able to produce a timely response to your request. regardless of the timeouts set in the vinyldns client http.Client.

Versions

github.com/vinyldns/go-vinyldns v0.9.16

@jhg03a jhg03a changed the title Add retry logic to RecordSetChangesListAll Add retry logic to RecordSetChangesListAll and RecordSetsListAll Apr 21, 2022
@jhg03a
Copy link
Contributor Author

jhg03a commented Apr 21, 2022

With RecordSetChangesListAll I can effectively reimplement the function with retry logic because the underlying RecordSetChanges function is exported. This is not the case however with RecordSetsListAll and the underlying recordSetsList function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant