Fix IPv6 Idempotency #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses inconsistency with if ipv6 addresses from the vinyldns api have square brackets or not. Fixes vinyldns#94
|
@remerle Would you mind taking a look at this as well? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses inconsistency with if ipv6 addresses from the vinyldns api have square brackets or not.
Description of the Change
Why Should This Be In The Package?
Benefits
This enables you to run terraform plan to know if there's work to do.
Possible Drawbacks
None that I can foresee.
Verification Process
I compiled this PR and transplanted it into my reproduce case leveraging TF11 and this fixed it.
Applicable Issues (Optional)
Fixes #94