We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This change: d35ee70#diff-384bc38b113bf1202dd85dbd22ddee20345c21ef44a92fdde5fae2abd083ab7fR64-R70 added the .isFile and .canExecute checks for "z3", but in scala this only checks if ./z3 exists (it is not true that execute_command(z3Path) doesn't error ==> z3Path.isFile && z3Path.canExecute since z3 can be found in the PATH). I'd suggest removing the checks here: https://github.com/viperproject/silicon/blob/master/src/main/scala/decider/ProverStdIO.scala#L115-L119 And wrap this line: https://github.com/viperproject/silicon/blob/master/src/main/scala/decider/ProverStdIO.scala#L136 in a try catch, if we really want to transform the IOException into an ExternalToolError.
.isFile
.canExecute
./z3
execute_command(z3Path) doesn't error ==> z3Path.isFile && z3Path.canExecute
z3
IOException
ExternalToolError
The text was updated successfully, but these errors were encountered:
No branches or pull requests
This change: d35ee70#diff-384bc38b113bf1202dd85dbd22ddee20345c21ef44a92fdde5fae2abd083ab7fR64-R70 added the
.isFile
and.canExecute
checks for "z3", but in scala this only checks if./z3
exists (it is not true thatexecute_command(z3Path) doesn't error ==> z3Path.isFile && z3Path.canExecute
sincez3
can be found in the PATH). I'd suggest removing the checks here:https://github.com/viperproject/silicon/blob/master/src/main/scala/decider/ProverStdIO.scala#L115-L119
And wrap this line:
https://github.com/viperproject/silicon/blob/master/src/main/scala/decider/ProverStdIO.scala#L136
in a try catch, if we really want to transform the
IOException
into anExternalToolError
.The text was updated successfully, but these errors were encountered: