Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type EPaymentGetPaymentOKResponse missing property metadata #19

Closed
melanki opened this issue Jan 4, 2024 · 3 comments
Closed

Type EPaymentGetPaymentOKResponse missing property metadata #19

melanki opened this issue Jan 4, 2024 · 3 comments
Assignees

Comments

@melanki
Copy link

melanki commented Jan 4, 2024

According to Vipps ePayment API specs the object GetPaymentResponse should have the property metadata.
During migration from vipps-sdk we discovered that this property is no longer available in this new SDK.

Could this be corrected? As we are using this to add metadata required by our eCommerce solution.

@tomas-zijdemans-vipps
Copy link
Collaborator

Thanks so much for reporting @melanki. I have done an initial investigation and can confirm that you are correct. The current epayment types lack metadata (and also receipt - so I will do a QA of all the ePayment types).

Please note that these types are copied from the old SDK, so this has been a bug all along (for both the old and new SDK).

I'll release a fix as soon as possible. Please feel free to send in any other issues, questions or just general feedback on the SDK! 👍

@tomas-zijdemans-vipps tomas-zijdemans-vipps self-assigned this Jan 5, 2024
@tomas-zijdemans-vipps
Copy link
Collaborator

This should fix the issue: #22. Please verify once this has been merged :)

@tomas-zijdemans-vipps
Copy link
Collaborator

Fixed in 0.6.0

Please let us know if you have further issues, questions or feedback :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants