Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Can't compile after updating to deck.gl 9.0.1 (regression) #8711

Closed
7 tasks
ruizmarc opened this issue Mar 27, 2024 · 2 comments
Closed
7 tasks

[Bug] Can't compile after updating to deck.gl 9.0.1 (regression) #8711

ruizmarc opened this issue Mar 27, 2024 · 2 comments
Labels

Comments

@ruizmarc
Copy link

Description

I cannot compile application with deck.gl 9.0.1. I could compile without any problem with previous version 8.9.21.

Flavors

  • Script tag
  • React
  • Python/Jupyter notebook
  • MapboxOverlay
  • GoogleMapsOverlay
  • CartoLayer
  • ArcGIS

Expected Behavior

I should be able to compile the application

Steps to Reproduce

I have an angular application using deck.gl, and when I try to compile it, it crashes with the error shown in logs.

I tried both webpack builder and application builder with esbuild, but I get the same error. I tried both angular 16 and angular 17. In both cases crashes with deck.gl 9.0.1 and it works fine with 8.9.21.

I'm using using different layers such as Heatmap, IconLayer, TextLayer and ScatterplotLayer.

Environment

Deps:
"@deck.gl/aggregation-layers": "^9.0.1",
"@deck.gl/core": "^9.0.1",
"@deck.gl/google-maps": "^9.0.1",
"@deck.gl/layers": "^9.0.1",

  • Framework version: Angular 16 and Angular 17
  • Browser: Any
  • OS: Any

Logs

Application bundle generation failed. [27.793 seconds]

✘ [ERROR] TS2307: Cannot find module 'modules/core/src/lib/attribute/attribute' or its corresponding type declarations. [plugin angular-compiler]

 node_modules/@deck.gl/aggregation-layers/dist/aggregation-layer.d.ts:16:29:
   16 │ ...ring]: import("modules/core/src/lib/attribute/attribute").default;
      ╵                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

✘ [ERROR] TS2307: Cannot find module '../...js' or its corresponding type declarations. [plugin angular-compiler]

 node_modules/@luma.gl/core/dist/adapter/resources/render-pass.d.ts:5:28:
   5 │ import { NumberArray } from "../...js";
     ╵                             ~~~~~~~~~~

✘ [ERROR] TS2307: Cannot find module '../...js' or its corresponding type declarations. [plugin angular-compiler]

 node_modules/@luma.gl/core/dist/adapter/type-utils/vertex-format-from-attribute.d.ts:1:50:
   1 │ import { TypedArray, TypedArrayConstructor } from "../...js";
     ╵                                                   ~~~~~~~~~~

✘ [ERROR] TS2307: Cannot find module '../...js' or its corresponding type declarations. [plugin angular-compiler]

 node_modules/@luma.gl/shadertools/dist/modules-webgl1/project/project.d.ts:1:29:
   1 │ import { ShaderModule } from "../...js";
     ╵                              ~~~~~~~~~~
@ruizmarc ruizmarc added the bug label Mar 27, 2024
@ruizmarc ruizmarc changed the title [Bug] Can't compile after updating to deck.gl 9.0.1 [Bug] Can't compile after updating to deck.gl 9.0.1 (regression) Mar 27, 2024
@donmccurdy
Copy link
Collaborator

donmccurdy commented Mar 27, 2024

node_modules/@deck.gl/aggregation-layers/dist/aggregation-layer.d.ts:16:29:
16 │ ...ring]: import("modules/core/src/lib/attribute/attribute").default;
╵ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I'll make a PR for this error. Looks like @ibgreen is already working on the others with PRs in lumagl.

@Pessimistress
Copy link
Collaborator

Fixes are published in v9.0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants