From cc428c85c5ce95e2793891abb598b7c8de9886f2 Mon Sep 17 00:00:00 2001 From: Bhushan Palsapure Date: Tue, 27 Aug 2024 16:05:57 +0100 Subject: [PATCH 1/2] Updated : Issue 1978 - Changes to footer based on `intranet` implementation findings --- components/vf-footer/CHANGELOG.md | 4 ++++ components/vf-footer/vf-footer.njk | 4 ++-- components/vf-footer/vf-footer.scss | 32 ++++++++++++++++++++++++++++- 3 files changed, 37 insertions(+), 3 deletions(-) diff --git a/components/vf-footer/CHANGELOG.md b/components/vf-footer/CHANGELOG.md index e991a3ceb8..0e6601e66b 100755 --- a/components/vf-footer/CHANGELOG.md +++ b/components/vf-footer/CHANGELOG.md @@ -1,3 +1,7 @@ +### 1.2.1 + +* Changes to footer based on `intranet` implementation findings [Tracking issue](https://github.com/visual-framework/vf-core/issues/1978) + ### 1.2.0 * Requires at least `@visual-framework@vf-sass-config@2.6.1`. diff --git a/components/vf-footer/vf-footer.njk b/components/vf-footer/vf-footer.njk index fcc69d08c1..33f5372033 100755 --- a/components/vf-footer/vf-footer.njk +++ b/components/vf-footer/vf-footer.njk @@ -93,8 +93,8 @@ - - + Maybe an address too, 5555, Somewhere, Earth. + Tel: +49 00 000 000. Another entry diff --git a/components/vf-footer/vf-footer.scss b/components/vf-footer/vf-footer.scss index cf973cd30b..18e2cc0950 100755 --- a/components/vf-footer/vf-footer.scss +++ b/components/vf-footer/vf-footer.scss @@ -88,7 +88,8 @@ .vf-footer__legal-text, .vf-footer__link { - padding-top: 12px; + padding-top: 6px; + padding-bottom: 6px; } @media (min-width: $vf-breakpoint--lg) { @@ -118,6 +119,7 @@ border-width: 1px 0; margin-bottom: 12px; padding-bottom: 24px; + grid-template-columns: repeat(5, 1fr); .vf-links__heading { @include set-type(text-body--6, $custom-margin-bottom: 8px, $color: ignore); @@ -197,3 +199,31 @@ } } } + +@media (max-width: 768px) { + + .vf-footer__links-group { + grid-template-columns: repeat(3, 1fr); + + .vf-list__item { + padding-top: 10px; + padding-bottom: 10px; + } + } + + .vf-footer__legal .vf-footer__legal-text, .vf-footer__legal .vf-footer__link { + padding-top: 14px; + padding-bottom: 14px; + } + + .vf-footer .vf-grid { + grid-row-gap: 0rem; + } +} + +@media (max-width: 600px) { + + .vf-footer__links-group { + grid-template-columns: repeat(1, 1fr); + } +} From a7b9c5286943ed09f0a25a7cfa7b6bfe6264fdba Mon Sep 17 00:00:00 2001 From: Bhushan Palsapure Date: Tue, 3 Sep 2024 10:23:30 +0100 Subject: [PATCH 2/2] Updated : Issue 1978 - Changes to footer based on `intranet` implementation findings --- components/vf-footer/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/vf-footer/CHANGELOG.md b/components/vf-footer/CHANGELOG.md index 0e6601e66b..c6cc60396e 100755 --- a/components/vf-footer/CHANGELOG.md +++ b/components/vf-footer/CHANGELOG.md @@ -1,6 +1,6 @@ ### 1.2.1 -* Changes to footer based on `intranet` implementation findings [Tracking issue](https://github.com/visual-framework/vf-core/issues/1978) +* Changes to footer based on `EMBL-EBI Intranet` implementation findings [Tracking issue](https://github.com/visual-framework/vf-core/issues/1978) ### 1.2.0