Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-vue): distinguish HMR and transform descriptor #227

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Aug 12, 2023

Description

Distinguish HMR and transform descriptor

Transform descriptors are not the same as HMR descriptors. Transform one will be transformed by Vite plugin, but HMR one is read from filesystem directly (without transform)

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sxzz sxzz merged commit aa2b59d into vitejs:main Aug 14, 2023
7 checks passed
@sxzz sxzz changed the title fix: distinguish HMR and transform descriptor fix(plugin-vue): distinguish HMR and transform descriptor Aug 14, 2023
@sxzz sxzz deleted the fix/hmr-cache branch August 14, 2023 09:32
@rashfael
Copy link
Contributor

rashfael commented Sep 9, 2023

This also fixes my issue with HMR and style-only changes #211 . Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants