Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@vitejs/plugin-legacy CSP hashes outdated #13373

Closed
1 of 4 tasks
nightvisi0n opened this issue May 30, 2023 · 0 comments · Fixed by #13384
Closed
1 of 4 tasks

@vitejs/plugin-legacy CSP hashes outdated #13373

nightvisi0n opened this issue May 30, 2023 · 0 comments · Fixed by #13384
Labels
contribution welcome documentation Improvements or additions to documentation plugin: legacy

Comments

@nightvisi0n
Copy link

Documentation is

  • Missing
  • Outdated
  • Confusing
  • Not sure?

Explain in Detail

The third hash listed in https://github.com/vitejs/vite/tree/main/packages/plugin-legacy#content-security-policy, appears to be outdated.

The hashes returned from import { cspHashes } from '@vitejs/plugin-legacy' using v4.0.3:

  • sha256-MS6/3FCg4WjP9gwgaBGwLpRCY6fZBgwmhVCdrPrNf3E=
  • sha256-tQjf8gvb2ROOMapIxFvFAYBeUJ0v1HCbOcSmDNXGtDo=
  • sha256-4y/gEB2/KIwZFTfNqwXJq4olzvmQ0S214m9jwKgNXoc=
  • sha256-+5XkZFazzJo8n0iOP4ti/cLCMUudTf//Mzkb7xNPXIc=

Related: #12112

Your Suggestion for Changes

Update the README.md file in @vitejs/plugin-legacy to have correct hashes.
Should there also be added an automatic CI test that e.g. checks that the hashes in cspHashes from @vitejs/plugin-legacy exists in the README.md in order to ensure it does not get outdated again?

Reproduction

No response

Steps to reproduce

No response

@nightvisi0n nightvisi0n added the documentation Improvements or additions to documentation label May 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution welcome documentation Improvements or additions to documentation plugin: legacy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants