Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(plugin-legacy): fix typo #13936

Merged
merged 1 commit into from
Jul 23, 2023
Merged

docs(plugin-legacy): fix typo #13936

merged 1 commit into from
Jul 23, 2023

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Jul 23, 2023

Description

Seems to be a typo false should be true with option ignoreBrowserslistConfig.

Additional context

### `ignoreBrowserslistConfig`

- **Type:** `boolean`
- **Default:** `false`

  `@babel/preset-env` automatically detects [`browserslist` config sources](https://github.com/browserslist/browserslist#browserslist-):

  - `browserslist` field in `package.json`
  - `.browserslistrc` file in cwd.

  Set to `false` to ignore these sources.

Should be logical:

Set to true to ignore these sources.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Jul 23, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@Rotzbua Rotzbua changed the title doc(plugin-legacy): fix typo docs(plugin-legacy): fix typo Jul 23, 2023
`false` should be `true`
@bluwy bluwy merged commit 28ddd43 into vitejs:main Jul 23, 2023
@bluwy
Copy link
Member

bluwy commented Jul 23, 2023

Thanks!

@Rotzbua Rotzbua deleted the patch-1 branch July 23, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants