Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0 Beta 10+] file change Watch no longer detect changes in workspace since Rollup 4 #14927

Closed
7 tasks done
ghiscoding opened this issue Nov 9, 2023 · 0 comments · Fixed by #14938
Closed
7 tasks done
Assignees
Labels
p4-important Violate documented behavior or significantly improves performance (priority)

Comments

@ghiscoding
Copy link
Contributor

ghiscoding commented Nov 9, 2023

Describe the bug

I have 2 monorepo workspace projects which I tried to upgrade to Vite 5.0 Beta 17, both projects are using pnpm workspace (with workspace:* protocol), prior to Beta 10 (which is the Rollup 4 upgrade) the watch worked correctly. However it regressed in Beta 10 and it stopped detecting file changed in the workspace. I tried many Beta versions to find out that the regression started with Beta 10 and higher which was the switch to Rollup 4.

I went back to Vite 4.5 for now (or I could also use Vite 5.0-beta.9 which works) because the watch still works correctly in my monorepo project with old version. Hopefully this gets fixed so I can upgrade back to 5.0 :)

Reproduction

https://github.com/ghiscoding/multiple-select-vanilla

Steps to reproduce

steps to install the monorepo

  1. git clone https://github.com/ghiscoding/multiple-select-vanilla
  2. upgrade to Vite 5 Beta 10 or higher in lib/package.json and demo/package.json
  3. pnpm install
  4. pnpm run dev
  5. make a change in any file from the lib/ package and it should do a full page reload in the browser (I use full page refresh because it's a monorepo structure)

System Info

System:
    OS: Windows 10 10.0.19045
    CPU: (20) x64 12th Gen Intel(R) Core(TM) i7-12800H
    Memory: 8.29 GB / 31.67 GB
  Binaries:
    Node: 18.18.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.19 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 9.8.1 - C:\Program Files\nodejs\npm.CMD
    pnpm: 8.10.2 - ~\AppData\Local\pnpm\pnpm.EXE
  Browsers:
    Edge: Spartan (44.19041.3570.0), Chromium (118.0.2088.76)
    Internet Explorer: 11.0.19041.3570

Used Package Manager

pnpm

Logs

No response

Validations

@ghiscoding ghiscoding changed the title [5.0 Beta 10+] file change watch no longer detect changes in monorepo since Beta10 aka Rollup 4 [5.0 Beta 10+] file change watch no longer detect changes in monorepo since Rollup 4 Nov 9, 2023
@ghiscoding ghiscoding changed the title [5.0 Beta 10+] file change watch no longer detect changes in monorepo since Rollup 4 [5.0 Beta 10+] file change Watch no longer detect changes in workspace since Rollup 4 Nov 9, 2023
@sapphi-red sapphi-red added the p4-important Violate documented behavior or significantly improves performance (priority) label Nov 10, 2023
@sapphi-red sapphi-red self-assigned this Nov 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p4-important Violate documented behavior or significantly improves performance (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants