Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-legacy): fix type errors #4762

Merged
merged 1 commit into from
Sep 18, 2021
Merged

fix(plugin-legacy): fix type errors #4762

merged 1 commit into from
Sep 18, 2021

Conversation

llc1123
Copy link
Contributor

@llc1123 llc1123 commented Aug 27, 2021

Description

Fixed multiple typecheck errors from TypeScript.

Additional context

plugin-legacy/index.js l180: the return type is incomplete (and having a syntax error).
plugin-legacy/index.js l547: polyfillChunk could be type RollupWatcher which doesn't have the output property.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

fix multiple typecheck error from typescript
@llc1123 llc1123 changed the title fix: fix type errors fix(plugin-legacy): fix type errors Aug 28, 2021
@antfu antfu merged commit 5491143 into vitejs:main Sep 18, 2021
ygj6 pushed a commit to ygj6/vite that referenced this pull request Sep 22, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants