Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-vite): migrate lit-element to lit #5012

Merged
merged 8 commits into from
Sep 25, 2021
Merged

Conversation

rodydavis
Copy link
Contributor

Description

This PR migrates lit-element to lit as per the launch of Lit 2 today.

Additional context

Breaking change with imports and template name.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on the release @rodydavis! 🚀

The PR looks good but looks like there are a few files unrelated to this PR that are changed. Could you remove them from the change set? Thanks!

@Shinigami92 Shinigami92 added the p2-nice-to-have Not breaking anything but nice to have (priority) label Sep 21, 2021
@Shinigami92 Shinigami92 self-requested a review September 21, 2021 21:13
packages/create-vite/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@YunYouJun YunYouJun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do not need package-lock.json in template. (Because users may use different package managers.)

Files about ssr-vue were changed, they seem unnecessary.

@rodydavis
Copy link
Contributor Author

Ill work on removing those now

ar7casper and others added 2 commits September 24, 2021 19:59
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Co-authored-by: Alex Raihelgaus <alex@thesashka.com>
@rodydavis rodydavis reopened this Sep 25, 2021
@rodydavis
Copy link
Contributor Author

Should be ready to review now!

packages/playground/ssr-vue/example-external-component/ExampleExternalComponent.vue is not removing for some reason

patak-dev
patak-dev previously approved these changes Sep 25, 2021
@patak-dev
Copy link
Member

patak-dev commented Sep 25, 2021

Edit: nvm, looks like this is something related to the new setup. This used to work for me to test templates before, taking them out of the pnpm workspace fixed this

@patak-dev patak-dev dismissed their stale review September 25, 2021 07:22

see comment

@patak-dev
Copy link
Member

@rodydavis after we merge this one, it would be great if you could make another PR later to improve the lit templates, following the way other framework templates. You could add a bit of styling, a centered Lit logo, and links to the official docs to help people get started. I don't know if you are around in Vite Land but we can also discuss this in the #lit channel.

@patak-dev patak-dev merged commit d66ea0f into vitejs:main Sep 25, 2021
@rodydavis
Copy link
Contributor Author

Would love to update the templates! I have some ideas to show off some of the features

@patak-dev
Copy link
Member

Would love to update the templates! I have some ideas to show off some of the features

Awesome! I think it is a good idea to check the other templates. We shouldnt add a complete showcase (a link to one would be better). We are trying to keep the templates as minimal as possible (no SSR, etc) to avoid maintenance burden.

noriyotcp added a commit to noriyotcp/create-vite-pwa that referenced this pull request Oct 22, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants