Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-react): respect opts.fastRefresh in viteBabel #5139

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

IanVS
Copy link
Contributor

@IanVS IanVS commented Sep 29, 2021

Description

I found that the fastRefresh option in plugin-react was not entirely preventing fast-refresh from being added to my files, which was causing them to blow up in my testing environment.

The change here is to respect the option as well as the existing production / build checks.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@IanVS
Copy link
Contributor Author

IanVS commented Sep 30, 2021

Updated to use logical OR assignment. Also, the failing test looks like flake to me, but LMK if there's anything else you'd like.

@patak-dev patak-dev changed the title fix: [plugin-react] Respect opts.fastRefresh in viteBabel fix(plugin-react): respect opts.fastRefresh in viteBabel Sep 30, 2021
@patak-dev patak-dev merged commit 5cf4e69 into vitejs:main Sep 30, 2021
@patak-dev
Copy link
Member

Updated to use logical OR assignment. Also, the failing test looks like flake to me, but LMK if there's anything else you'd like.

Yes, we are having issues with the tests like last time you were helping.

@IanVS IanVS deleted the skip-refresh branch September 30, 2021 13:02
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants