vite build fails when using build.rollupOptions.external together with <link rel="stylesheet">

[eemeli]

Describe the bug

If the build.rollupOptions.external config option includes a CSS file as a path, a <link rel="stylesheet"> tag matching that path is incorrectly removed from the index.html file and inserted into the JS file, breaking the result as it's then left there as import "...css" by Rollup due to the external config. This only affects the production build, as in dev mode the <link> is left intact and works as expected.

In the code, this looks like the culprit:

vite/packages/vite/src/node/plugins/html.ts

Lines 216 to 220 in e8c840a

	const isExcludedUrl = (url: string) =>
	url.startsWith('#') ||
	isExternalUrl(url) ||
	isDataUrl(url) ||
	checkPublicFile(url, config)

vite/packages/vite/src/node/plugins/html.ts

Lines 324 to 331 in e8c840a

	if (!isExcludedUrl(url)) {
	if (node.tag === 'link' && isCSSRequest(url)) {
	// CSS references, convert to import
	js += `\nimport ${JSON.stringify(url)}`
	shouldRemove = true
	} else {
	assetUrls.push(p)
	}

I'm willing to file a PR fixing this, if it's okay to introduce a dependency in buildHtmlPlugin() on the value of the build.rollupOptions.external config option?

Reproduction

https://gist.github.com/eemeli/97b34dc72c886dffa25168699fe81e79

System Info

System:
    OS: macOS 12.1
    CPU: (8) arm64 Apple M1
    Memory: 73.81 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 17.4.0 - /opt/homebrew/bin/node
    Yarn: 1.22.11 - /opt/homebrew/bin/yarn
    npm: 8.3.1 - /opt/homebrew/bin/npm
  Browsers:
    Chrome: 98.0.4758.80
    Firefox: 96.0.3
    Safari: 15.2
  npmPackages:
    vite: ^2.8.0 => 2.8.2

Used Package Manager

npm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[poyoho]

now It seems to call warning for this case even no setting build.rollupOptions.external. So can I close this issues?

[eemeli]

Sure. We ended up not using Vite after all, so I can't easily test the current behaviour.