-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: worker emit fileName with config #7804
Conversation
const workerConfig = workerOutputConfig | ||
? Array.isArray(workerOutputConfig) | ||
? workerOutputConfig[0] || {} | ||
: workerOutputConfig | ||
: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I miss one point.
Array.isArray(workerOutputConfig)
? workerOutputConfig[0] || {}
: workerOutputConfig
It is always using the first item. Can we limit the type just accept object? @patak-dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw this and it makes sense in this context. We could warn if there are two output options maybe
Description
fix: #7613
fix: #7928
fix: #8089
Additional context
emitFile
chunk’s fileName. So we can use this chunk’s fileName directly.entryFileNames, chunkFileNames, assetFileNames
make the file into truth path.emitFile
with same filename.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).