refactor: ExportData.imports
to ExportData.hasImports
#8355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ExportData.imports
was only used forimport.length > 0
.Rewrote
imports
intohasImports
to remove depending ones-module-lexer
's type.refs #8352
Additional context
ExportData
types needs to be exported becauseoptimizeDeps
which is exported fromsrc/node/index.ts
returnsDepOptimizationMetadata
type includingExportData
typeoptimizeDeps
could be changed toPromise<void>
to avoid breaking change. I think the return type ofoptimizeDeps
is too specific if it is considered as an public api.optimizeDeps
is used only from the cliresolvedConfig.createResolver
's param type isInternalResolveOptions
and it includesExportData
getDepsOptimizer
could be removed fromresolvedConfig.createResolver
's param typeWhat is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).