fix(optimizer): external require-import conversion (fixes #2492, #3409, #5308) #8459
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses esbuild's plugin hook to convert
require
intoimport
even if it is externalized. (refs: #2492 (comment))a minimal require-import conversion plugin: https://stackblitz.com/edit/node-xh6pvc?file=build.js
fixes #2492
fixes #3409
fixes #5308
I tested with #3409's repro.
Additional context
I think this approach is faster and less-fragile than regex or parsing + replacing. But it heavily depends on esbuild's plugin behavior and it might unveil an edge case bug of esbuild.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).