Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(create-vite): update logo and header styles #8502

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jun 8, 2022

Description

On Safari, there's an odd box clipping around the glow. Adding will-change: filter fixes it.

image

Also add line-spacing to heading text on small width:

Before:
image

After:
image

Additional context

Guess it would be cool to add a glow for each respective frameworks color too


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy marked this pull request as draft June 8, 2022 07:55
@patak-dev
Copy link
Member

Ya, a beter color for each may look better. And maybe three lines more of CSS is justified

@bluwy bluwy marked this pull request as ready for review June 8, 2022 07:59
@bluwy bluwy changed the title chore(create-vite): add will-change for logo chore(create-vite): update logo and header styles Jun 8, 2022
@bluwy
Copy link
Member Author

bluwy commented Jun 8, 2022

This is good now. Sorry had to snuck another change 😬

@patak-dev patak-dev merged commit 1f1ca5e into vitejs:main Jun 8, 2022
@bluwy bluwy deleted the create-vite-glow branch June 8, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants