fix(ssr): use appendRight for import #9554
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes SSR transfoming
preact/compat/dist/compat.module.js
noticed in withastro/astro#4093 (comment)Also looks like this was also reported long ago at #2479
Additional context
The issue is of magic-string's semantics of
appendLeft
andappendRight
. Since preact's bundled code is minified, the issue is prevalent. Here's a stackblitz of a gist of what's happening.We're experiencing the first code example in the stackblitz link, so the solution is to use
appendRight()
so that the content isn't removed when we're removing code in front of it (aka left side). And also do an earlyremove()
instead, otherwise it would remove the code we added viaappendRight()
.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).