Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): use appendRight for import #9554

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 5, 2022

Description

Fixes SSR transfoming preact/compat/dist/compat.module.js noticed in withastro/astro#4093 (comment)

Also looks like this was also reported long ago at #2479

Additional context

The issue is of magic-string's semantics of appendLeft and appendRight. Since preact's bundled code is minified, the issue is prevalent. Here's a stackblitz of a gist of what's happening.

We're experiencing the first code example in the stackblitz link, so the solution is to use appendRight() so that the content isn't removed when we're removing code in front of it (aka left side). And also do an early remove() instead, otherwise it would remove the code we added via appendRight().


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vite-ecosystem-ci is all green with this PR, I think it is safe to merge it to be released in the next patch.

https://github.com/vitejs/vite-ecosystem-ci/actions/runs/2820358104

@patak-dev patak-dev merged commit dfec6ca into main Aug 8, 2022
@patak-dev patak-dev deleted the ssr-fix-import-export-handling branch August 8, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: ssr p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants