fix: prevent error overlay style being overridden (fixes #9969) #9971
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, error overlay uses
:host
to declare styles for the root element.vite/packages/vite/src/client/overlay.ts
Lines 5 to 6 in 4158b98
But when a style is declared for that element like
*
.https://github.com/vuejs/create-vue/blob/2f2b040e5a73093926be0f69054a9616918ba5b8/template/base/src/assets/base.css#L53-L58
It gets overridden by that.
For #9969,
position: fixed
was overridden withposition: relative
.fixes #9969
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).