Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky Test: vipersync.TestPersistConfig #13380

Closed
ajm188 opened this issue Jun 26, 2023 · 0 comments · Fixed by #13185
Closed

Flaky Test: vipersync.TestPersistConfig #13380

ajm188 opened this issue Jun 26, 2023 · 0 comments · Fixed by #13185
Assignees
@ajm188
Labels
Component: Build/CI Type: Bug Type: Testing

Comments

@ajm188
Copy link
Contributor

ajm188 commented Jun 26, 2023

Overview of the Issue

The vipersync.TestPersistConfig tests are extremely flaky in CI, and slightly less so on a local machine.

We've skipped them for now, but we need to rewrite these tests to re-enable them, as that code is currently untested.

Reproduction Steps

go test -race run "TestPersistConfig" ./go/viperutil/internal/vipersync

Binary Version

main

Operating System and Environment details

N/A

Log Fragments

No response
@ajm188 ajm188 added Type: Bug Needs Triage This issue needs to be correctly labelled and triaged Component: Build/CI Type: Testing and removed Needs Triage This issue needs to be correctly labelled and triaged labels Jun 26, 2023
@ajm188 ajm188 self-assigned this Jun 26, 2023
@ajm188 ajm188 mentioned this issue Jun 26, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajm188 ajm188

Labels
Component: Build/CI Type: Bug Type: Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CI] deflake viper sync tests planetscale/vitess
1 participant
@ajm188