Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Improvements to PRS #13686

Closed
GuptaManan100 opened this issue Aug 2, 2023 · 0 comments · Fixed by #13623
Closed

Feature Request: Improvements to PRS #13686

GuptaManan100 opened this issue Aug 2, 2023 · 0 comments · Fixed by #13623

Comments

@GuptaManan100
Copy link
Member

Feature Description

PlannedReparentShard is supposed to be only called when all the components are running fine. If a user calls PRS with a mysql instance of a replica not working fine, then PRS does fail, but only after promoting another replica. This isn't correct and we should fail without touching the cluster at all. The user should resolve all the problems before they try a planned reparent operation again.

Also, if a Primary Tablet is deleted and then PRS is called, it ends up running the code for the initialisation of a shard, which calls InitPrimary but this isn't correct either, because InitPrimary allows a primary to accept writes without semi-sync waits even if it is configured that way.

Use Case(s)

Improvements to PRS to better report errors and prevent its misuse.

@GuptaManan100 GuptaManan100 added Type: Feature Needs Triage This issue needs to be correctly labelled and triaged Component: Cluster management and removed Needs Triage This issue needs to be correctly labelled and triaged labels Aug 2, 2023
@GuptaManan100 GuptaManan100 mentioned this issue Aug 2, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant