Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Report: fastparse integer parsing can return the wrong value #13701

Closed
dbussink opened this issue Aug 3, 2023 · 0 comments · Fixed by #13702
Closed

Bug Report: fastparse integer parsing can return the wrong value #13701

dbussink opened this issue Aug 3, 2023 · 0 comments · Fixed by #13702
Assignees
@dbussink
Labels
Component: Evalengine changes to the evaluation engine Type: Bug

Comments

@dbussink
Copy link
Contributor

dbussink commented Aug 3, 2023

Overview of the Issue

fastparse.ParseUint64("31415926535897932384", 10)

This logic will return the wrong answer, giving 12969182462188380764 with no error instead of an error and the maximum value for a uint64.

Reproduction Steps

Binary Version

-

Operating System and Environment details

-

Log Fragments

No response
@dbussink dbussink added Type: Bug Component: Evalengine changes to the evaluation engine labels Aug 3, 2023
@dbussink dbussink self-assigned this Aug 3, 2023
@dbussink dbussink mentioned this issue Aug 3, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbussink dbussink

Labels
Component: Evalengine changes to the evaluation engine Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fastparse: Fix bug in overflow detection planetscale/vitess
1 participant
@dbussink