Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support arbitrary ZooKeeper config #13828

Closed
adsr opened this issue Aug 21, 2023 · 1 comment · Fixed by #13829
Closed

Feature Request: Support arbitrary ZooKeeper config #13828

adsr opened this issue Aug 21, 2023 · 1 comment · Fixed by #13829

Comments

@adsr
Copy link
Collaborator

adsr commented Aug 21, 2023

Feature Description

Add ability to add arbitrary config lines to ZooKeeper config via zkctl(d)

Use Case(s)

Currently zkctl(d) writes ZK config according to a template in the Vitess repo (zoo.cfg). There is no clean way to customize this config.

For example, we find it useful to add the following configs in our setup:

tcpKeepAlive=true
autopurge.snapRetainCount=10
autopurge.purgeInterval=24

Today we do this by running zkctl init, then modifying the config, then proceeding with other zkctl commands. This feels hacky. Given zkctl is writing the config, it would be nice if zkctl itself supported this.

PR to follow.

@adsr adsr added Type: Feature Needs Triage This issue needs to be correctly labelled and triaged labels Aug 21, 2023
@frouioui frouioui added Component: Topology and removed Needs Triage This issue needs to be correctly labelled and triaged labels Aug 24, 2023
@adsr
Copy link
Collaborator Author

adsr commented Sep 20, 2023

Thank you @mattlord & team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants