Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: qualify generated sequence table name #17173

Closed
notfelineit opened this issue Nov 7, 2024 · 0 comments · Fixed by #17174
Closed

Feature Request: qualify generated sequence table name #17173

notfelineit opened this issue Nov 7, 2024 · 0 comments · Fixed by #17174
Assignees
Labels
Component: VReplication go Type: Enhancement Logical improvement (somewhere between a bug and feature)

Comments

@notfelineit
Copy link
Contributor

Feature Description

In #16860, Vitess added a feature that auto-created sequence tables for workflows created with --sharded-auto-increment-handling=replace.

Currently, the sequence table names generated in the VSchema are unqualified. This works for cases where the sequence table is unique across al keyspaces.

In the case that a sequence table name might exist in multiple keyspaces, we would have to qualify it. This feature request is to qualify the generated sequence table name with the keyspace from --global-keyspace.

Use Case(s)

If a table with the same name as the to-be-generated sequence (for some reason) already exists in a keyspace that is not the --global-keyspace, we would run into issues with the generated, unqualified sequence table name in the VSchema.

@notfelineit notfelineit added Needs Triage This issue needs to be correctly labelled and triaged Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: VReplication go labels Nov 7, 2024
@mattlord mattlord removed the Needs Triage This issue needs to be correctly labelled and triaged label Nov 7, 2024
@mattlord mattlord self-assigned this Nov 7, 2024
@github-project-automation github-project-automation bot moved this to Backlog in VReplication Nov 7, 2024
@mattlord mattlord moved this from Backlog to Prioritized in VReplication Nov 7, 2024
@github-project-automation github-project-automation bot moved this from Prioritized to Done in VReplication Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VReplication go Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
Status: Done
2 participants