Bug Report: VReplication unable to complete/terminate on MySQL error 1180 (ER_ERROR_DURING_COMMIT)

[shlomi-noach]

Overview of the Issue

If MySQL returns error code 1180 (ER_ERROR_DURING_COMMIT), the binlog connection auto-closes:

vitess/go/vt/binlog/binlogplayer/dbclient.go

Lines 108 to 111 in 216fd70

	if err != nil {
	LogError("COMMIT failed w/ error", err)
	dc.dbConn.Close()
	}

And it is then subsequently unable to setMessage in:

vitess/go/vt/vttablet/tabletmanager/vreplication/vreplicator.go

Lines 189 to 192 in 216fd70

	if err != nil {
	if err := vr.setMessage(err.Error()); err != nil {
	binlogplayer.LogError("Failed to set error state", err)
	}

because it uses that same (now closed) connection.

This then means vreplication does not persist the failure, and keeps on retrying the same step infinitely (or until the MySQL response is different from 1180).

Reproduction Steps

Return error code 1180 from MySQL during vreplication. This is a rare code which I've only encountered during some internal testing.

Binary Version

all

Operating System and Environment details

any

Log Fragments

No response