Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Upgrade the Golang version to go1.21.4 #14488

Merged
merged 3 commits into from
Nov 10, 2023
Merged

[main] Upgrade the Golang version to go1.21.4 #14488

merged 3 commits into from
Nov 10, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 8, 2023 •
edited by harshit-gangal
Loading

This Pull Request bumps the Golang version to go1.21.4 and the bootstrap version to 25.

Do not trust the bot blindly. A thorough code review must be done to ensure all the files have been correctly modified.

There are a few manual steps remaining:

  • Make sure you update the Golang version used in the previous and next release branches for the Upgrade/Downgrade tests.
  • Build and Push the bootstrap images to Docker Hub, the bot cannot handle that.
  • Update the ./.github/workflows/*.yml files with the newer Golang version, the bot cannot handle that due to permissions.
    • To accomplish this, run the following: go run ./go/tools/go-upgrade/go-upgrade.go upgrade workflows --go-to=1.21.4

@frouioui
bump go version to go1.21.4
3c40349 
Signed-off-by: GitHub <noreply@github.com>
@github-actions github-actions bot added Benchmark me Add label to PR to run benchmarks Component: General Changes throughout the code base labels Nov 8, 2023
@github-actions github-actions bot requested a review from frouioui as a code owner November 8, 2023 00:21
@github-actions github-actions bot added the go label Nov 8, 2023
@github-actions github-actions bot added Skip CI Skip CI actions from running Type: CI/Build labels Nov 8, 2023
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 8, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 8, 2023

Hello! 👋

This Pull Request is now handled by arewefastyet. The current HEAD and future commits will be benchmarked.

You can find the performance comparison on the arewefastyet website.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 8, 2023
@harshit-gangal
updated workflow
76cda61 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says Skip CI Skip CI actions from running NeedsIssue A linked issue is missing for this Pull Request labels Nov 10, 2023
@harshit-gangal
Empty-Commit
d711188 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal merged commit d964876 into main Nov 10, 2023
227 checks passed
@harshit-gangal harshit-gangal deleted the upgrade-go-to-1.21.4-on-main branch November 10, 2023 12:20
@frouioui frouioui added this to the v19.0.0 milestone Dec 11, 2023
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
@github-actions @frouioui
@harshit-gangal @ejortegau
[main] Upgrade the Golang version to go1.21.4 (vitessio#14488)
eeac346 
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: frouioui <frouioui@users.noreply.github.com>
Co-authored-by: Harshit Gangal <harshit@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@dkhenry dkhenry Awaiting requested review from dkhenry

Assignees
No one assigned
Labels
Benchmark me Add label to PR to run benchmarks Component: General Changes throughout the code base go Type: CI/Build
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@harshit-gangal @frouioui