Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix relevant files listing for endtoend CI #15104

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Fix relevant files listing for endtoend CI #15104

merged 2 commits into from
Feb 1, 2024

Conversation

shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Feb 1, 2024 •
edited by deepthi
Loading

Description

This adds the following as "relevant files" to CI endtoend tests, so that tests are not skipped:

  • sidecardb schema files
  • OnlineDDL vreplication test files

let's backport, even the sidecardb changes, those are harmless, and it's safer if we ensure all tests run as opposed to not.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach
go/test/endtoend/onlineddl/vrepl_suite/ changes should kick CI
aaa8b55 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
inbclude sidecardb files
12ec438 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@github-actions github-actions bot added this to the v19.0.0 milestone Feb 1, 2024
deepthi
deepthi approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to backport? We won't be changing sidecardb schema in older releases, but what about vrepl test files?

@shlomi-noach
Copy link
Contributor Author

shlomi-noach commented Feb 1, 2024 •
edited
Loading

Yes, let's backport, even the sidecardb changes, those are harmless, and it's safer if we ensure all tests run as opposed to not.

@shlomi-noach shlomi-noach added Backport to: release-16.0 Component: General Changes throughout the code base and removed Component: General Changes throughout the code base labels Feb 1, 2024
@shlomi-noach shlomi-noach merged commit 131dccc into vitessio:main Feb 1, 2024
104 of 106 checks passed
@shlomi-noach shlomi-noach deleted the fix-ci-relevant-files branch February 1, 2024 14:38
This was referenced Feb 1, 2024
Merged
Merged
vitess-bot pushed a commit that referenced this pull request Feb 1, 2024
@vitess-bot
Fix relevant files listing for endtoend CI (#15104)
c059311 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@vitess-bot vitess-bot bot mentioned this pull request Feb 1, 2024
Merged
frouioui pushed a commit that referenced this pull request Feb 1, 2024
@shlomi-noach @frouioui
Fix relevant files listing for endtoend CI (#15104)
67009f0 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui pushed a commit that referenced this pull request Feb 1, 2024
@shlomi-noach @frouioui
Fix relevant files listing for endtoend CI (#15104)
84bcdb2 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui pushed a commit that referenced this pull request Feb 1, 2024
@vitess-bot @shlomi-noach
[release-16.0] Fix relevant files listing for endtoend CI (#15104) (#…
ec19c33 
…15108)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
frouioui added a commit that referenced this pull request Feb 1, 2024
@vitess-bot @frouioui
[release-18.0] Fix relevant files listing for endtoend CI (#15104) (#…
2934b0a 
…15110)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui pushed a commit that referenced this pull request Feb 1, 2024
@vitess-bot @shlomi-noach
[release-17.0] Fix relevant files listing for endtoend CI (#15104) (#…
ea1e3fe 
…15109)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@deepthi deepthi deepthi approved these changes

@dbussink dbussink dbussink approved these changes

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

Assignees
No one assigned
Labels
Component: Build/CI Type: CI/Build
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shlomi-noach @dbussink @deepthi @frouioui