-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-19.0] Upgrade the Golang version to go1.22.1
#15406
Conversation
Signed-off-by: GitHub <noreply@github.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Hello! 👋 This Pull Request is now handled by arewefastyet. The current HEAD and future commits will be benchmarked. You can find the performance comparison on the arewefastyet website. |
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-19.0 #15406 +/- ##
================================================
- Coverage 67.43% 67.43% -0.01%
================================================
Files 1560 1560
Lines 192642 192642
================================================
- Hits 129912 129902 -10
- Misses 62730 62740 +10 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
go.mod
Outdated
@@ -1,17 +1,17 @@ | |||
module vitess.io/vitess | |||
|
|||
go 1.22.0 | |||
go 1.22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frouioui This is broken, this needs to be 1.22.1
.
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
This Pull Request bumps the Golang version to
go1.22.1
and the bootstrap version to27.1
.There are a few manual steps remaining:
./.github/workflows/*.yml
files with the newer Golang version, the bot cannot handle that due to permissions.go run ./go/tools/go-upgrade/go-upgrade.go upgrade workflows --go-to=1.22.1