Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VTAdmin API] Replace underscores with dashes in cluster ID #15722

Draft
wants to merge 10,000 commits into
base: main
Choose a base branch
from
Draft

[VTAdmin API] Replace underscores with dashes in cluster ID #15722

wants to merge 10,000 commits into from
+1,823,522 −400,643

Conversation

notfelineit
Copy link
Contributor

@notfelineit notfelineit commented Apr 15, 2024 •
edited by deepthi
Loading

Description

VTAdmin API fails to connect to VTGate and vtctld when there are underscores _ in the VTGate & vtctld custom name resolvers. The custom name is based on the cluster ID, so this PR switches underscores for dashes - in the initial cluster ID.

This PR should be backported, since it fixes a bug that exists in v17-present.

Related Issue(s)

Fixes #15721

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

N/A

frouioui and others added 30 commits February 6, 2024 17:56
@frouioui @ajm188
Revert unwanted logging change to vttestserver (vitessio#15148)
1dd25ca 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
Co-authored-by: Andrew Mason <amason@hey.com>
Correctly set log_dir default in vtcombo (vitessio#15153)
c58bedb 
Signed-off-by: Andrew Mason <andrew@planetscale.com>
@beingnoble03
Fix evalEngine functions for dates on/before 0000-02-29 (vitessio#1…
7491cf5 
…5124)

Signed-off-by: Noble Mittal <noblemittal@outlook.com>
@systay
feat: use collation aware typing for UNION (vitessio#15122)
a674061 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@frouioui
Use latest go version in update golang version workflow (vitessio#15159)
b62905b 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot
[main] Add release-19.0 to the auto go upgrade (vitessio#15157) (vi…
4e80985 
…tessio#15168)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@systay
Copy v19.0.0-RC1 release notes on main (vitessio#15164)
64a357e 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@vmg
mysql: move colldump to its own standalone repository (vitessio#15166)
19c39f9 
Signed-off-by: Vicent Marti <vmg@strn.cat>
@github-actions @frouioui @vmg
[main] Upgrade the Golang version to go1.22.0 (vitessio#15167)
77589c2 
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Vicent Marti <vmg@strn.cat>
Co-authored-by: frouioui <frouioui@users.noreply.github.com>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Vicent Marti <vmg@strn.cat>
@systay @frouioui
Planner Bug: Joins inside derived table (vitessio#14974)
a98f6a9 
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andrés Taylor <andres@taylor.se>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
@GuptaManan100
Subqueries in SET condition of UPDATE statement in presence of foreig…
f50c0ca 
…n keys (vitessio#15163)

Signed-off-by: Manan Gupta <manan@planetscale.com>
@shlomi-noach
Throttler: fix nil pointer dereference error (vitessio#15180)
d285003 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@frouioui
Fix logging issue when running in Docker with the syslog daemon disab…
d86d180 
…led (vitessio#15176)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@mattlord
VReplication: Enforce consistent order for table copies and diffs (vi…
eec82c4 
…tessio#15152)

Signed-off-by: Matt Lord <mattalord@gmail.com>
@ejortegau
TxThrottler: dont throttle unless lag (vitessio#14789)
50bd383 
Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
@vmg @aquarapid
Make tablet collation mismatch warning throttled (vitessio#15123)
31625b8 
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
Signed-off-by: Vicent Marti <vmg@strn.cat>
Co-authored-by: aquarapid <aquarapid@gmail.com>
@beingnoble03
evalEngine: Implement SPACE, REVERSE (vitessio#15173)
e742b5a 
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
@GuptaManan100
Enable gRPC Server Side Keepalive settings (vitessio#14939)
079efc6 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@timvaillancourt
Load --grpc_auth_static_client_creds file once (vitessio#15030)
66b9b14 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
modernize various tests (vitessio#15184)
868319e 
Signed-off-by: Andrew Mason <andrew@planetscale.com>
@mattlord
CI: Use v3 of fossa-action and exclude maven (vitessio#15140)
472e251
@beingnoble03
evalEngine: Implement string INSERT (vitessio#15201)
dd7d2c8 
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
@systay @vmg
bugfix: wrong field type returned for SUM (vitessio#15192)
5b726fa 
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Vicent Marti <vmg@strn.cat>
Co-authored-by: Vicent Marti <vmg@strn.cat>
@whuang8
Remove loopclosure captures from tests (vitessio#15202)
d951e82 
Signed-off-by: William Huang <mail.william.huang@gmail.com>
@frouioui
Remove concurrency group for check labels workflow (vitessio#15197)
de118c8 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@GuptaManan100 @systay @harshit-gangal
Feature: Adding support for Vindex Hints to allow for greater control…
7c08431 
… over shard routing (vitessio#15172)

Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal @systay
Update with Limit Plan (vitessio#15107)
cb86254 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>
@dbussink
schemadiff: Clean up MySQL version from diff hints (vitessio#15210)
5b0c7ac 
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@dbussink
evalengine: Implement LOCATE and friends (vitessio#15195)
cc21b01 
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@VaibhavMalik4187
Added tests for the go/trace package (vitessio#15052)
919bde3 
Signed-off-by: VaibhavMalik4187 <vaibhavmalik2018@gmail.com>
@notfelineit
Copy link
Contributor Author

notfelineit commented Apr 19, 2024 •
edited
Loading

Ok, I'm back working on this!

@mattlord and @dbussink , I didn't originally intend to bundle the full fix with this PR, but I will now. The reason being I didn't want to make a decision on "break" or "fix silently" when users pass in an invalid cluster name. However, I think a reasonable first step might be to:

  • Maintain old behavior on "bad" cluster names (still spin up VTAdmin, vtctld and vtgate won't work) but add a log/notification letting the user know they should use a different cluster name

That changes things a bit, because I'm not sure if this PR should still automatically change _ to - then, because we should probably treat all invalid characters in the same way.

@ajm188 what do you think? Should we:

  • autofix the names
  • allow bad names and just notify the user
  • combination of the two: correct _ and warn on the rest

@dbussink
Copy link
Contributor

  • Maintain old behavior on "bad" cluster names (still spin up VTAdmin, vtctld and vtgate won't work) but add a log/notification letting the user know they should use a different cluster name

What about we add warning for now to not immediately break people and then we turn it into an error if you use an invalid name for the next release (v21)? That way we don't have to do anything here trying to interpret what the user intended long term.

@notfelineit
Copy link
Contributor Author

notfelineit commented Apr 22, 2024 •
edited
Loading

@dbussink Yeah, I think that's a good way to go about it. Including what @ajm188 said too! Here's the plan taken from everyone's input:

  1. v20: Add warning (log & warning in the UI) on invalid cluster name
  2. v21: Turn warning into an error on vtadmin-api boot up

And for clarification, we won't plan to auto format any cluster names!

This was referenced Apr 29, 2024
Closed
Closed
Closed
@github-actions GitHub Actions
Copy link
Contributor

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. and removed Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. labels May 23, 2024
@deepthi deepthi marked this pull request as draft May 31, 2024 16:47
@deepthi
Copy link
Member

deepthi commented May 31, 2024

Moving to draft until all changes are complete.

@frouioui frouioui modified the milestones: v20.0.0, v21.0.0 Jun 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. and removed Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. labels Aug 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. and removed Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. labels Sep 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Oct 3, 2024
@vitess-bot vitess-bot modified the milestones: v21.0.0, v22.0.0 Oct 8, 2024
@github-actions github-actions bot removed the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Oct 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2024

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Nov 9, 2024
@github-actions github-actions bot removed the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Nov 12, 2024
@harshit-gangal harshit-gangal force-pushed the replace-underscores-with-dashes-vtadmin branch from 3dce263 to 76b4ab3 Compare December 4, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajm188 ajm188 ajm188 approved these changes

@dbussink dbussink dbussink left review comments

@mattlord mattlord mattlord approved these changes

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 will be requested when the pull request is marked ready for review GuptaManan100 is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui will be requested when the pull request is marked ready for review frouioui is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi will be requested when the pull request is marked ready for review deepthi is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal will be requested when the pull request is marked ready for review harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay will be requested when the pull request is marked ready for review systay is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach will be requested when the pull request is marked ready for review shlomi-noach is a code owner

@timvaillancourt timvaillancourt Awaiting requested review from timvaillancourt timvaillancourt will be requested when the pull request is marked ready for review timvaillancourt is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins will be requested when the pull request is marked ready for review derekperkins is a code owner

@vmg vmg Awaiting requested review from vmg vmg will be requested when the pull request is marked ready for review vmg is a code owner

Assignees
No one assigned
Labels
Backport to: release-19.0 Needs to be back ported to release-19.0 Component: VTAdmin VTadmin interface go Type: Bug
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.

Bug Report: gRPC custom name resolvers don't work with underscores