fix: add 'assertType' to 'expect-expect' allowed assertions (#534)

vitest-dev · Sep 13, 2024 · fa377d7 · fa377d7
1 parent 016b071
commit fa377d7
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/src/rules/expect-expect.ts b/src/rules/expect-expect.ts
@@ -65,7 +65,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
     const unchecked: TSESTree.CallExpression[] = []
     const settings = parsePluginSettings(context.settings)
 
-    if (settings.typecheck) assertFunctionNames.push('expectTypeOf')
+    if (settings.typecheck) assertFunctionNames.push('expectTypeOf', 'assertType')
 
     function checkCallExpression(nodes: TSESTree.Node[]) {
       for (const node of nodes) {

diff --git a/tests/expect-expect.test.ts b/tests/expect-expect.test.ts
@@ -187,7 +187,7 @@ const it = base.extend<{
     },
     {
       code: `
-    it("should fail without 'typecheck' enabled", () => {
+    it("should fail 'expectTypeOf' without 'typecheck' enabled", () => {
      expectTypeOf({ a: 1 }).toEqualTypeOf<{ a: number }>()
     });
     `,
@@ -198,6 +198,19 @@ const it = base.extend<{
         }
       ]
     },
+    {
+      code: `
+    it("should fail 'assertType' without 'typecheck' enabled", () => {
+     assertType<string>('a')
+    });
+    `,
+      errors: [
+        {
+          messageId: 'noAssertions',
+          type: AST_NODE_TYPES.Identifier
+        }
+      ]
+    },
     {
       code: `
      import { it } from 'vitest';