valid-expect doesn't recognize the second parameter of expect

[fregante]

I have this line of code and valid-expect says it's invalid:

expect(fs.existsSync(filePath), `New feature name "${newName}" not found in source/features`).toBe(true);

You can see that it actually works and that it appears in the types, added in 2022.

Here's a simple version:

expect(false, 'CUSTOM ERROR').toBe(true);

[veritem]

@fregante valid-expect requires setup maximum args when you use more than one argument. refer to this

eslint-plugin-vitest/tests/valid-expect.test.ts

Line 92 in 65cc22c

options: [{ maxArgs: 2 }]

[fregante]

What's the point? expect(x, message) is valid, why is this rule not accepting it as valid as a default? If anything, specifying a better message should be the preferred version, not considered invalid by default.

[azu]

I've created a PR to fix this issue.

• fix(valid-expect): allow expect(value, "message") #518

This PR allow to use expect(value, "string literal").toBe(1) as exception of this rule.