Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Blocklist' of IDs which should not appear in Result Lists #221

Open
silvanheller opened this issue Sep 24, 2021 · 1 comment
Open

'Blocklist' of IDs which should not appear in Result Lists #221

silvanheller opened this issue Sep 24, 2021 · 1 comment
Labels
enhancement Good First Issue Good Issue for first-time contributors help wanted

Comments

@silvanheller
Copy link
Member

silvanheller commented Sep 24, 2021

For some of the datasets commonly used with vitrivr, there might be items which should not appear in results when the general public can interact with demos. Instead of having the effort of separate deployments, a very simple solution would be as follows:

  • There is a new config field blocked_object_ids which could for example be populated as follows: [v_0007, v_01240, is_2016_04_20]`
  • In the ContinuousRetrievalLogic, simply remove all SegmentScoreElements which contain a blocked id. This might result in config values not being exactly followed, but that is an acceptable tradeoff for public demos.

For new Contributors

Feel free to set up the stack: https://vitrivr.org/getting_started.html. Afterwards, have a look at the implementation suggestion above and feel free to get started.

@silvanheller silvanheller added enhancement help wanted Good First Issue Good Issue for first-time contributors labels Sep 24, 2021
@lucaro
Copy link
Member

lucaro commented Sep 24, 2021

I get your point, although I'm not a fan of having a simple black list. If such a mechanism is introduced, why not turn it into a proper access management mechanism, which could then also be extended to take into account where a query is coming from?

@vitrivr vitrivr deleted a comment from Ejaz29 Jan 24, 2022
@vitrivr vitrivr deleted a comment from vaibhav0806 Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Good First Issue Good Issue for first-time contributors help wanted
Projects
None yet
Development

No branches or pull requests

2 participants