Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI usability fixes #1601

Merged
merged 2 commits into from
Nov 12, 2023
Merged

UI usability fixes #1601

merged 2 commits into from
Nov 12, 2023

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Nov 12, 2023

Summary:

This PR:

  • Removes the 2 px margin on the sidebar.
  • Changes when the editor auto-completer is triggered to only be activated on single keypresses (add or delete) and nothing else. It was triggering on other document change events that were not user-initiated, like during loading of a document when the cursor had last been positioned at a tag/reference line.
  • Changes the auto-replace feature to also run on keywords again. It has accidentally been disabled on such lines.

Related Issue(s):

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.2 RC 1 milestone Nov 12, 2023
@vkbo vkbo changed the base branch from main to dev November 12, 2023 20:37
@vkbo vkbo merged commit 0b35227 into dev Nov 12, 2023
9 checks passed
@vkbo vkbo deleted the minor_fixes branch November 12, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant