Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline if statement generates C error with struct option fields #19477

Closed
islonely opened this issue Sep 30, 2023 · 1 comment · Fixed by #19485
Closed

inline if statement generates C error with struct option fields #19477

islonely opened this issue Sep 30, 2023 · 1 comment · Fixed by #19485
Assignees
Labels
Bug This tag is applied to issues which reports bugs. Build V build error on any OS/CPU architecture. Unit: cgen Bugs/feature requests, that are related to the default C generating backend.

Comments

@islonely
Copy link
Contributor

islonely commented Sep 30, 2023

Describe the bug

C error is produced when assigning string in if clause and none in else clause to option field of struct with inline if statements.

Reproduction Steps

struct Foo {
mut:
	option ?string
}

fn main() {
	mut foo := Foo{}
	some_val := 1
	foo.option = if some_val > 0 {
		'awesome'
	} else {
		none
	}
}

Expected Behavior

Expected code to compile. No output.

Current Behavior

Generates C error. Edit: forgot to add the C error 😅

C:/Users/imado/AppData/Local/Temp/v_0/test.5766870113736213155.tmp.c:499: warning: WINVER redefined
C:/Users/imado/AppData/Local/Temp/v_0/test.5766870113736213155.tmp.c:6796: warning: implicit declaration of function 'tcc_backtrace'
C:/Users/imado/AppData/Local/Temp/v_0/test.5766870113736213155.tmp.c:12566: error: declaration of an array of incomplete type elements
builder error: 
==================
C error. This should never happen.

Possible Solution

No response

Additional Information/Context

No response

V version

V full version: V 0.4.1 68cbf27.24278d8

Environment details (OS name and version, etc.)

V full version: V 0.4.1 68cbf27.24278d8
OS: windows, Microsoft Windows 11 Pro v22621 64-bit
Processor: 16 cpus, 64bit, little endian, 

getwd: C:\frostbyte
vexe: C:\Users\imado\v\v.exe
vexe mtime: 2023-09-29 19:06:29

vroot: OK, value: C:\Users\imado\v
VMODULES: OK, value: C:\Users\imado\.vmodules
VTMP: OK, value: C:\Users\imado\AppData\Local\Temp\v_0

Git version: git version 2.33.1.windows.1
Git vroot status: weekly.2023.39-20-g24278d82 (1 commit(s) behind V master)
.git/config present: true

CC version: Error: 'cc' is not recognized as an internal or external command,
operable program or batch file.

thirdparty/tcc status: thirdparty-windows-amd64 e90c2620

Note

You can vote for this issue using the 👍 reaction. More votes increase the issue's priority for developers.

Take into account that only the 👍 reaction counts as a vote.
Only reactions to the issue itself will be counted as votes, not comments.

@islonely islonely added the Bug This tag is applied to issues which reports bugs. label Sep 30, 2023
@islonely
Copy link
Contributor Author

This is the C it generates that causes the error.

_option_string _t2; /* if prepend */
if (some_val > 0) {
	_option_ok(&(void[]) { _SLIT("awesome") }, (_option*)(&_t2), sizeof(void));
} else {
	_t2.state = 2;
	_t2.err = _const_none__;
}
foo.option =  _t2;

@ArtemkaKun ArtemkaKun added Unit: cgen Bugs/feature requests, that are related to the default C generating backend. Build V build error on any OS/CPU architecture. labels Sep 30, 2023
@felipensp felipensp self-assigned this Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This tag is applied to issues which reports bugs. Build V build error on any OS/CPU architecture. Unit: cgen Bugs/feature requests, that are related to the default C generating backend.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants