Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C error from optional reference default value set to unsafe { nil } #19538

Closed
islonely opened this issue Oct 9, 2023 · 3 comments · Fixed by #19746
Closed

C error from optional reference default value set to unsafe { nil } #19538

islonely opened this issue Oct 9, 2023 · 3 comments · Fixed by #19746
Assignees
Labels
Bug This tag is applied to issues which reports bugs. Build V build error on any OS/CPU architecture. Unit: cgen Bugs/feature requests, that are related to the default C generating backend.

Comments

@islonely
Copy link
Contributor

islonely commented Oct 9, 2023

Describe the bug

C error is generated from field ?&Struct = unsafe { nil }. Can't imagine why anyone would ever want that. Discovered it on accident when switching some &Struct types to ?&Struct.

Reproduction Steps

struct View {
	parent ?&View = unsafe { nil }
}

fn main() {
	_ := &View{}
}

Expected Behavior

Expected code to compile

Current Behavior

C:/Users/imado/AppData/Local/Temp/v_0/test.tmp.c:495: warning: WINVER redefined
C:/Users/imado/AppData/Local/Temp/v_0/test.tmp.c:6755: warning: implicit declaration of function 'tcc_backtrace'
C:/Users/imado/AppData/Local/Temp/v_0/test.tmp.c:12677: error: lvalue expected
builder error: 
==================
C error. This should never happen.

Possible Solution

No response

Additional Information/Context

No response

V version

V 0.4.2 37e5616

Environment details (OS name and version, etc.)

V full version: V 0.4.2 37e5616
OS: windows, Microsoft Windows 11 Pro v22621 64-bit
Processor: 16 cpus, 64bit, little endian, 

getwd: C:\Users\imado\Documents\GitHub\lena
vexe: C:\Users\imado\v\v.exe
vexe mtime: 2023-10-09 22:29:31

vroot: OK, value: C:\Users\imado\v
VMODULES: OK, value: C:\Users\imado\.vmodules
VTMP: OK, value: C:\Users\imado\AppData\Local\Temp\v_0

Git version: git version 2.33.1.windows.1
Git vroot status: weekly.2023.40.1-50-g37e5616b
.git/config present: true

CC version: Error: 'cc' is not recognized as an internal or external command,
operable program or batch file.

thirdparty/tcc status: thirdparty-windows-amd64 e90c2620

Note

You can vote for this issue using the 👍 reaction. More votes increase the issue's priority for developers.

Take into account that only the 👍 reaction counts as a vote.
Only reactions to the issue itself will be counted as votes, not comments.

@islonely islonely added the Bug This tag is applied to issues which reports bugs. label Oct 9, 2023
@ArtemkaKun ArtemkaKun added Unit: cgen Bugs/feature requests, that are related to the default C generating backend. Build V build error on any OS/CPU architecture. labels Oct 10, 2023
@felipensp
Copy link
Member

Should we still allowing assigning unsafe { nil } to an option @spytheman ?

@medvednikov
Copy link
Member

@felipensp I think we shouldn't

@felipensp
Copy link
Member

@felipensp I think we shouldn't

Thanks @medvednikov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This tag is applied to issues which reports bugs. Build V build error on any OS/CPU architecture. Unit: cgen Bugs/feature requests, that are related to the default C generating backend.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants