Skip to content
This repository has been archived by the owner on Mar 3, 2022. It is now read-only.

Configuration table is hard to read #55

Open
lentzi90 opened this issue Oct 29, 2018 · 6 comments
Open

Configuration table is hard to read #55

lentzi90 opened this issue Oct 29, 2018 · 6 comments

Comments

@lentzi90
Copy link

Several charts use a table with parameter, description and default value columns. Unfortunately, it is very hard to read the tables because of the narrow column used for the content. See Prometheus for an example.

I'm not suggesting that we just change the max-width. This would make the rest of the text hard to read with too long lines. Maybe there could be a separate section just for the table, with full width?

What do you think?

@prydonius
Copy link
Contributor

Agreed @lentzi90, it does look pretty difficult to read. I'm not sure how much control we have over the table rendering since we're just using https://github.com/markedjs/marked. @Angelmmiguel any ideas?

@Angelmmiguel
Copy link
Contributor

Angelmmiguel commented Oct 31, 2018

You're right @prydonius. Since we're rendering the markdown file it's quite complicated to customize the table. The same issue happens on Github: https://github.com/helm/charts/tree/master/stable/prometheus#configuration.

We can make more obvious you need to scroll the table using an inner shadow. However, that's not gonna solve the readability issue.

Another option could be to include an "expand table" button that removes the overflow: auto; property:

Table without overflow: auto

We can modify how marked renders the table using the renderer helpers: https://marked.js.org/#/USING_PRO.md.

What do you think @prydonius @lentzi90 ?

@prydonius
Copy link
Contributor

@Angelmmiguel to clarify, are you suggesting having the table always be expanded, or to have a button next to it to expand it? I think the latter could be very useful, the former might end up hiding other elements.

@Angelmmiguel
Copy link
Contributor

Angelmmiguel commented Oct 31, 2018

@prydonius yea, I'm talking about adding a button to expand the table (toggle). The button will be showed when users' mouse is hover the table. This button will toggle the overflow property for the table.

To highlight the table is expanded and avoid issues with the right sidebar, I'd add a high z-index and a box-shadow to the table when it's expanded.

@prydonius
Copy link
Contributor

@Angelmmiguel that sounds good to me!

@lentzi90
Copy link
Author

lentzi90 commented Nov 1, 2018

This sounds good to me as well! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants