Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two calendar icons are displayed for a date input in Firefox #208

Open
3 of 8 tasks
grahamford opened this issue Jan 27, 2023 · 3 comments
Open
3 of 8 tasks

Two calendar icons are displayed for a date input in Firefox #208

grahamford opened this issue Jan 27, 2023 · 3 comments

Comments

@grahamford
Copy link

Describe the bug

A date input control in Firefox displays a native browser calendar icon in addition to the cds-icon.

(Only a single cds-icon is displayed in Safari and Chrome.)

How to reproduce

View the Storybook page in Firefox https://storybook.core.clarity.design/?path=/story/forms-date--page

Screenshot 2023-01-27 at 09 58 30

Expected behavior

A single calendar icon is displayed in all browsers.

Versions

Clarity project:

  • Clarity Core
  • Clarity Angular/UI

Clarity version:

  • v5.x
  • v6.x

Framework:

  • Angular
  • React
  • Vue
  • Other:

Framework version:

Angular 15

Device:

  • Type: MacBook
  • OS: Ventura 13.2
  • Browser: Firefox
  • Version: 109
@Jinnie
Copy link
Contributor

Jinnie commented Feb 6, 2023

It's a regression caused by Firefox breaking change.
It was fine when I tested it with 107.0.1 and then I reproduced it in 109.0.1, after I updated my browser.
We have to check how to suppress the default icon.

@Jinnie Jinnie added the type:fix label Feb 6, 2023
@Jinnie
Copy link
Contributor

Jinnie commented Feb 6, 2023

It's actually the whole native selector that needs to be prevented.
It seems it does not respect the ::-webkit-calendar-picker-indicator pseudo selector anymore.

@grahamford
Copy link
Author

There doesn't seem to have been any change in Firefox according to this bug report https://bugzilla.mozilla.org/show_bug.cgi?id=1812397

Does anyone have a good workaround?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants