Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CdsButton and CdsControlAction not receiving keydown events in tests #218

Open
3 of 8 tasks
dturcotte opened this issue Mar 16, 2023 · 1 comment
Open
3 of 8 tasks

Comments

@dturcotte
Copy link

Describe the bug

onKeyDown is never fired during tests for components CdsControlAction and CdsButton. I first noticed this in CdsControlAction and reproduced it in CdsButton while making the repro, so maybe it's an issue with the base button?

How to reproduce

Here's a repo that reproduces the problem: https://github.com/dturcotte/cds-control-action-keydown
(stackblitz/codesandbox are problematic for test only repros)

The test output is in the README for your convenience

Steps to reproduce the behavior:

  1. Clone repo
  2. yarn install
  3. yarn test
  4. See the CdsButton and CdsControlAction tests fail, and the <button> test passes

Expected behavior

onKeyDown should work in tests

Versions

Clarity project:

  • Clarity Core
  • Clarity Angular/UI

Clarity version:

  • v5.x
  • v6.x

Framework:

  • Angular
  • React
  • Vue
  • Other:

Framework version:
React 18

Device:

  • Type: [e.g. MacBook] MacBook
  • OS: [e.g. iOS] Big Sur
  • Browser [e.g. chrome, safari] Chrome
  • Version [e.g. 22] 110.0.5481.177

Additional notes

@astorije
Copy link
Contributor

astorije commented Jul 5, 2023

(Definitely still a thing re: flag:stale label)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants