Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdfFileIcon] unclear where to import the pdf file icon from #241

Open
cianmcgovern93 opened this issue May 25, 2023 · 2 comments
Open

[pdfFileIcon] unclear where to import the pdf file icon from #241

cianmcgovern93 opened this issue May 25, 2023 · 2 comments

Comments

@cianmcgovern93
Copy link

To use the icon ...shape="pdf-file"... I noticed it had to be imported from
import { pdfFileIcon } from "@cds/core/icon/shapes/pdf-file";
I would have assumed I would have been able to import it from "@cds/core/icon" like other icons.

The documents should be updated to clearly show where to import the pdf icon from or better still it would be great to be able to import the icon via the path "@cds/core/icon" like other icons.

This caused a bit of confusion for me yesterday and it would be great to rectify this.

@abonhote
Copy link

Hey @cianmcgovern93 - did you manage to sort this out? I'm struggling with the docs too, one small real life example with icons would help a lot.

@kevinbuhmann
Copy link
Member

I think was fixed in #240. Please check with the latest version of @cds/core.

@kevinbuhmann kevinbuhmann transferred this issue from vmware-clarity/ng-clarity Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants